Skip to content

fix: Add no_source hint to prevent a sink-only table marked as source - #2213

Closed
ferenc-csaky wants to merge 1 commit into
mainfrom
fix/no-source-batch-sinks
Closed

fix: Add no_source hint to prevent a sink-only table marked as source#2213
ferenc-csaky wants to merge 1 commit into
mainfrom
fix/no-source-batch-sinks

Conversation

@ferenc-csaky

@ferenc-csaky ferenc-csaky commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Key Chnages

  • Introduce no_source table hint to prevent marking a sink-only table as a source, which can lead to Flink planning errors
  • Improve error message in case of unbounded source failure in batch mode
  • Add a DAG planner and usecase test that covers the added logic

@ferenc-csaky ferenc-csaky added bug Something isn't working enhancement New feature or request labels Jul 14, 2026
@ferenc-csaky ferenc-csaky added this to the 0.10.9 milestone Jul 14, 2026
@ferenc-csaky
ferenc-csaky force-pushed the fix/no-source-batch-sinks branch from 18ddf97 to 57b1156 Compare July 14, 2026 15:12
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 10.52632% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.46%. Comparing base (ba53588) to head (57b1156).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...com/datasqrl/error/ValidationExceptionHandler.java 0.00% 7 Missing ⚠️
...n/java/com/datasqrl/planner/hint/NoSourceHint.java 0.00% 5 Missing ⚠️
.../com/datasqrl/planner/Sqrl2FlinkSQLTranslator.java 0.00% 4 Missing ⚠️
...n/java/com/datasqrl/planner/hint/PlannerHints.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2213      +/-   ##
============================================
- Coverage     16.47%   16.46%   -0.01%     
  Complexity     1034     1034              
============================================
  Files           620      622       +2     
  Lines         17941    17957      +16     
  Branches       2194     2195       +1     
============================================
+ Hits           2956     2957       +1     
- Misses        14680    14695      +15     
  Partials        305      305              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@ferenc-csaky ferenc-csaky changed the title fix: Add no_source table hint to prevent a sink-only table marked as source fix: Add no_source hint to prevent a sink-only table marked as source Jul 14, 2026
@ferenc-csaky

Copy link
Copy Markdown
Collaborator Author

Superseded by #2218

@ferenc-csaky ferenc-csaky removed this from the 0.10.9 milestone Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants